Re: [Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogus V=0 variable

[Eric Blake]

On 01/23/2018 10:47 AM, Daniel P. Berrange wrote:
> The make rules for building QEMU are mostly silent by default. They can
> be made verbose by setting the variable V=1. The default state does not
> however correspond to a V=0 setting - $(V) must be undefined / empty to
> get the default quiet build.

Makefiles generated by automake support V=0; how hard would it be to
instead tweak things so that 'V=' and 'V=0' have the same effect?

> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index c263190b8d..554ba69ced 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -940,4 +940,5 @@ ifdef QEMU_GA_MSI_ENABLED
>  endif
>       @echo  ''
>  endif
> -     @echo  '  $(MAKE) V=0|1 [targets] 0 => quiet build (default), 1 => 
> verbose build'
> +     @echo  '  $(MAKE) [targets]      (quiet build, default)'
> +     @echo  '  $(MAKE) V=1 [targets]  (verbose build)'
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature