qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 00/10] Interactive Boot Menu for DASD and SCS


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 00/10] Interactive Boot Menu for DASD and SCSI Guests on s390x
Date: Tue, 23 Jan 2018 13:18:14 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 01/23/2018 12:26 PM, Collin L. Walling wrote:
> --- [v4] ---
> 
> This round mostly includes some general cleanup to bootmap.c. Checkpatch did 
> not like any variation of "strtoi", so I properly implemented atoi instead.

strtol is actually a better interface than atoi (as it can report
errors); but for a fallback code used only on known boot parameters,
implementing the simpler atoi is probably fine.

> 
>   - itostr and atoi now handle negative numbers (though not necessary 
>       for these patches, it is available for robustness)


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]