[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 13/13] linux-user: implement renameat2
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PULL 13/13] linux-user: implement renameat2 |
Date: |
Tue, 23 Jan 2018 21:13:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
Le 23/01/2018 à 20:13, Palmer Dabbelt a écrit :
> On Tue, 23 Jan 2018 06:48:07 PST (-0800), address@hidden wrote:
>> From: Andreas Schwab <address@hidden>
>>
>> This is needed for new architectures like RISC-V which do not provide any
>> other rename-like syscall.
>>
>> Signed-off-by: Andreas Schwab <address@hidden>
>> Reviewed-by: Laurent Vivier <address@hidden>
>> Message-Id: <address@hidden>
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>> linux-user/syscall.c | 34 ++++++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index 104408c050..74378947f0 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -600,6 +600,24 @@ static int sys_utimensat(int dirfd, const char
>> *pathname,
>> #endif
>> #endif /* TARGET_NR_utimensat */
>>
>> +#ifdef TARGET_NR_renameat2
>> +#if defined(__NR_renameat2)
>> +#define __NR_sys_renameat2 __NR_renameat2
>> +_syscall5(int, sys_renameat2, int, oldfd, const char *, old, int, newfd,
>> + const char *, new, unsigned int, flags)
>> +#else
>> +static int sys_renameat2(int oldfd, const char *old,
>> + int newfd, const char *new, int flags)
>> +{
>> + if (flags == 0) {
>> + return renameat(oldfd, old, newfd, new);
>> + }
>> + errno = ENOSYS;
>> + return -1;
>> +}
>> +#endif
>> +#endif /* TARGET_NR_renameat2 */
>> +
>> #ifdef CONFIG_INOTIFY
>> #include <sys/inotify.h>
>>
>> @@ -8426,6 +8444,22 @@ abi_long do_syscall(void *cpu_env, int num,
>> abi_long arg1,
>> }
>> break;
>> #endif
>> +#if defined(TARGET_NR_renameat2)
>> + case TARGET_NR_renameat2:
>> + {
>> + void *p2;
>> + p = lock_user_string(arg2);
>> + p2 = lock_user_string(arg4);
>> + if (!p || !p2) {
>> + ret = -TARGET_EFAULT;
>> + } else {
>> + ret = get_errno(sys_renameat2(arg1, p, arg3, p2, arg5));
>> + }
>> + unlock_user(p2, arg4, 0);
>> + unlock_user(p, arg2, 0);
>> + }
>> + break;
>> +#endif
>> #ifdef TARGET_NR_mkdir
>> case TARGET_NR_mkdir:
>> if (!(p = lock_user_string(arg1)))
>
> Thanks! My patch got lost in the shuffle, but I think these are
> functionally identical. Feel free to add my
I've seen your patch, but Andreas has implemented what was requested by
Peter (use renameat() when flags == 0), so I took his one.
> Reviewed-by: Palmer Dabbelt <address@hidden>
To late for that (it's a pull request), sorry.
Thank you,
Laurent
- [Qemu-devel] [PULL 00/13] Linux user for 2.12 patches, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 01/13] linux-user: Fix locking order in fork_start(), Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 05/13] linux-user: Translate flags argument to dup3 syscall, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 03/13] linux-user: Fix length calculations in host_to_target_cmsg(), Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 08/13] linux-user: Add AT_SECURE auxval, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 09/13] linux-user: Add getcpu() support, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 10/13] linux-user: remove nmi.c and fw-path-provider.c, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 13/13] linux-user: implement renameat2, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 02/13] linux-user: wrap fork() in a start/end exclusive section, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 04/13] linux-user: Don't use CMSG_ALIGN(sizeof struct cmsghdr), Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 07/13] linux-user: Fix sched_get/setaffinity conversion, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 11/13] linux-user: Propagate siginfo_t through to handle_cpu_signal(), Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 12/13] page_unprotect(): handle calls to pages that are PAGE_WRITE, Laurent Vivier, 2018/01/23
- [Qemu-devel] [PULL 06/13] linux-user/mmap.c: Avoid choosing NULL as start address, Laurent Vivier, 2018/01/23
- Re: [Qemu-devel] [PULL 00/13] Linux user for 2.12 patches, Peter Maydell, 2018/01/25