qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL] qemu-sparc updates


From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PULL] qemu-sparc updates
Date: Thu, 25 Jan 2018 13:48:27 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 25/01/18 12:51, Peter Maydell wrote:

On 24 January 2018 at 19:58, Mark Cave-Ayland
<address@hidden> wrote:
Hi Peter,

Here are the latest updates for SPARC. Please pull.


ATB,

Mark.


The following changes since commit 52483b067cce4a88ffbf8fbeea26de7549d2ad23:

   Merge remote-tracking branch 'remotes/huth/tags/pull-request-2018-01-22' 
into staging (2018-01-23 10:15:09 +0000)

are available in the git repository at:

   https://github.com/mcayland/qemu.git tags/qemu-sparc-signed

for you to fetch changes up to 9a323c89102f741e3a91a42906c26186a43f379e:

   sun4u: implement power device (2018-01-24 19:46:10 +0000)

----------------------------------------------------------------
qemu-sparc update


Hi; I'm afraid this has format-string issues:

In file included from hw/sparc64/trace.h:69:0,
                  from hw/sparc64/trace.c:4:
hw/sparc64/trace.h: In function '_nocheck__trace_sparc64_cpu_tick_set_count':
hw/sparc64/trace.h:466:23: error: format '%lx' expects argument of
type 'long unsigned int', but argument 6 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                        "address@hidden:sparc64_cpu_tick_set_count " "%s
set_count count=0x%016lx (npt %s) p=%p" "\n",
                        ^
/home/peter.maydell/qemu/include/qemu/log.h:94:22: note: in definition
of macro 'qemu_log_mask'
              qemu_log(FMT, ## __VA_ARGS__);              \
                       ^
hw/sparc64/trace.h: In function '_nocheck__trace_sparc64_cpu_tick_get_count':
hw/sparc64/trace.h:490:23: error: format '%lx' expects argument of
type 'long unsigned int', but argument 6 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                        "address@hidden:sparc64_cpu_tick_get_count " "%s
get_count count=0x%016lx (npt %s) p=%p" "\n",
                        ^
/home/peter.maydell/qemu/include/qemu/log.h:94:22: note: in definition
of macro 'qemu_log_mask'
              qemu_log(FMT, ## __VA_ARGS__);              \
                       ^
hw/sparc64/trace.h: In function '_nocheck__trace_sparc64_cpu_tick_set_limit':
hw/sparc64/trace.h:514:23: error: format '%lx' expects argument of
type 'long unsigned int', but argument 6 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                        "address@hidden:sparc64_cpu_tick_set_limit " "%s
set_limit limit=0x%016lx (%s) p=%p called with limit=0x%016lx at
0x%016lx (delta=0x%016lx)" "\n",
                        ^
/home/peter.maydell/qemu/include/qemu/log.h:94:22: note: in definition
of macro 'qemu_log_mask'
              qemu_log(FMT, ## __VA_ARGS__);              \
                       ^
hw/sparc64/trace.h:514:23: error: format '%lx' expects argument of
type 'long unsigned int', but argument 9 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                        "address@hidden:sparc64_cpu_tick_set_limit " "%s
set_limit limit=0x%016lx (%s) p=%p called with limit=0x%016lx at
0x%016lx (delta=0x%016lx)" "\n",
                        ^
/home/peter.maydell/qemu/include/qemu/log.h:94:22: note: in definition
of macro 'qemu_log_mask'
              qemu_log(FMT, ## __VA_ARGS__);              \
                       ^
hw/sparc64/trace.h:514:23: error: format '%lx' expects argument of
type 'long unsigned int', but argument 10 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                        "address@hidden:sparc64_cpu_tick_set_limit " "%s
set_limit limit=0x%016lx (%s) p=%p called with limit=0x%016lx at
0x%016lx (delta=0x%016lx)" "\n",
                        ^
/home/peter.maydell/qemu/include/qemu/log.h:94:22: note: in definition
of macro 'qemu_log_mask'
              qemu_log(FMT, ## __VA_ARGS__);              \
                       ^
hw/sparc64/trace.h:514:23: error: format '%lx' expects argument of
type 'long unsigned int', but argument 11 has type 'uint64_t {aka long
long unsigned int}' [-Werror=format=]
                        "address@hidden:sparc64_cpu_tick_set_limit " "%s
set_limit limit=0x%016lx (%s) p=%p called with limit=0x%016lx at
0x%016lx (delta=0x%016lx)" "\n",
                        ^
/home/peter.maydell/qemu/include/qemu/log.h:94:22: note: in definition
of macro 'qemu_log_mask'
              qemu_log(FMT, ## __VA_ARGS__);              \
                       ^

Printing uint64_t requires the PRIx64 macros.

Sorry yes, those format strings were taken from some very old code so I should have paid a bit more attention.

I've fixed up these events and re-pushed the qemu-sparc-signed tag to github which should resolve the issue.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]