[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/3] Usb 20180125 patches
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PULL 0/3] Usb 20180125 patches |
Date: |
Thu, 25 Jan 2018 17:24:50 +0100 |
User-agent: |
NeoMutt/20171215 |
On Thu, Jan 25, 2018 at 03:28:38PM +0000, Peter Maydell wrote:
> On 25 January 2018 at 09:16, Gerd Hoffmann <address@hidden> wrote:
> > Thomas Huth (1):
> > usb: Remove legacy -usbdevice options (host, serial, disk and net)
>
> Hi. This fails to build on FreeBSD:
>
> LINK arm-softmmu/qemu-system-arm
> ../vl.o: In function `usb_device_add':
> /root/qemu/vl.c:1471: undefined reference to `usb_host_device_open'
>
> There's still a call to that function in vl.c inside an
> ifndef CONFIG_LINUX...
>
> If we can really remove the function we should get rid of the
> stub in hw/usb/host-stub.c and the prototype in usb.h too.
Indeed. I'll fix it up.
The lines in vl.c dead code anyway since we switched to libusb and
dropped the linux/bsd specific usb-host code, so it all can simply be
deleted.
cheers,
Gerd
- [Qemu-devel] [PULL 0/3] Usb 20180125 patches, Gerd Hoffmann, 2018/01/25
- [Qemu-devel] [PULL 2/3] hw/usb/ccid: Make ccid_card_init() take an error parameter, Gerd Hoffmann, 2018/01/25
- [Qemu-devel] [PULL 3/3] usb-storage: Fix share-rw option parsing, Gerd Hoffmann, 2018/01/25
- [Qemu-devel] [PULL 1/3] usb: Remove legacy -usbdevice options (host, serial, disk and net), Gerd Hoffmann, 2018/01/25
- Re: [Qemu-devel] [PULL 0/3] Usb 20180125 patches, Peter Maydell, 2018/01/25
- Re: [Qemu-devel] [PULL 0/3] Usb 20180125 patches,
Gerd Hoffmann <=