Re: [Qemu-devel] [PATCH v10.5 14/20] target/arm: Use vector infrastructure for aa64 dup/movi

[Peter Maydell]

On 17 January 2018 at 16:14, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/translate-a64.c | 83 
> +++++++++++++++++++---------------------------
>  1 file changed, 34 insertions(+), 49 deletions(-)
>
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index 219cc1e19d..2495414603 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -5863,38 +5863,24 @@ static void disas_simd_across_lanes(DisasContext *s, 
> uint32_t insn)
>   *
>   * size: encoded in imm5 (see ARM ARM LowestSetBit())
>   */
> +

Stray whitespace change

>  static void handle_simd_dupe(DisasContext *s, int is_q, int rd, int rn,
>                               int imm5)
>  {
>      int size = ctz32(imm5);
> -    int esize = 8 << size;
> -    int elements = (is_q ? 128 : 64) / esize;
> -    int index, i;
> -    TCGv_i64 tmp;
> +    int index = imm5 >> (size + 1);
>
>      if (size > 3 || (size == 3 && !is_q)) {
>          unallocated_encoding(s);
>          return;
>      }
> -

Ditto.


Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM