[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 41/45] hw/hppa: Implement DINO system board
From: |
Helge Deller |
Subject: |
Re: [Qemu-devel] [PATCH v3 41/45] hw/hppa: Implement DINO system board |
Date: |
Sat, 27 Jan 2018 14:22:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
Hi Philipppe,
On 25.01.2018 12:22, Philippe Mathieu-Daudé wrote:
> Hi Richard, Helge,
>
> On 01/24/2018 08:26 PM, Richard Henderson wrote:
>> From: Helge Deller <address@hidden>
>>
>> Now that we have the prerequisites in target/hppa/,
>> implement the hardware for a PA7100LC.
>>
>> This also enables build for hppa-softmmu.
>>
>> Signed-off-by: Helge Deller <address@hidden>
>> [rth: Since it is all new code, squashed all branch development
>> withing hw/hppa/ to a single patch.]
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> Makefile.objs | 1 +
>> hw/hppa/hppa_hardware.h | 40 +++
>> hw/hppa/hppa_sys.h | 24 ++
>> hw/hppa/dino.c | 518
>> +++++++++++++++++++++++++++++++++++++++
>> hw/hppa/machine.c | 246 ++++++++++++++++++-
>> hw/hppa/pci.c | 90 +++++++
>> default-configs/hppa-softmmu.mak | 14 ++
>> hw/hppa/Makefile.objs | 2 +-
>> hw/hppa/trace-events | 4 +
>> 9 files changed, 937 insertions(+), 2 deletions(-)
>> create mode 100644 hw/hppa/hppa_hardware.h
>> create mode 100644 hw/hppa/hppa_sys.h
>> create mode 100644 hw/hppa/dino.c
>> create mode 100644 hw/hppa/pci.c
>> create mode 100644 default-configs/hppa-softmmu.mak
>> create mode 100644 hw/hppa/trace-events
...
>> +static ISABus *hppa_isa_bus(void)
>> +{
>> + ISABus *isa_bus;
>> + qemu_irq *isa_irqs;
>> + MemoryRegion *isa_region;
>> +
>> + isa_region = g_new(MemoryRegion, 1);
>> + memory_region_init_io(isa_region, NULL, &hppa_pci_ignore_ops,
>> + NULL, "isa-io", 0x800);
>> + memory_region_add_subregion(get_system_memory(), IDE_HPA,
>> + isa_region);
>> +
>> + isa_bus = isa_bus_new(NULL, get_system_memory(), isa_region,
>> + &error_abort);
>> + isa_irqs = i8259_init(isa_bus,
>> + /* qemu_allocate_irq(dino_set_isa_irq, s, 0)); */
>
> What is that commented? circular dependency problem?
No actual problem.
It's a left-over from copy&pasting during the development phase.
We don't use and need ISA irqs yet.
I left it in in case I'm going to expand it, but basically it can go.
Helge
>> + NULL);
>> + isa_bus_irqs(isa_bus, isa_irqs);
>> +
>> + return isa_bus;
>> +}
- [Qemu-devel] [PATCH v3 32/45] target/hppa: Only use EXCP_DTLB_MISS, (continued)
- [Qemu-devel] [PATCH v3 32/45] target/hppa: Only use EXCP_DTLB_MISS, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 34/45] target/hppa: Use MMU_DEBUG_LOAD when reloading for CR[IIR], Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 35/45] target/hppa: Increase number of temp regs, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 36/45] target/hppa: Fix comment, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 38/45] target/hppa: Implement a pause instruction, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 39/45] target/hppa: Implement STWA, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 37/45] target/hppa: Implement LDSID for system mode, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 40/45] target/hppa: Enable MTTCG, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 41/45] hw/hppa: Implement DINO system board, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 44/45] target/hppa: Fix 32-bit operand masks for 0E FCVT, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 43/45] hw/hppa: Add MAINTAINERS entry, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 45/45] target/hppa: Implement PROBE for system mode, Richard Henderson, 2018/01/24
- [Qemu-devel] [PATCH v3 42/45] pc-bios: Add hppa-firmware.img and git submodule, Richard Henderson, 2018/01/24
- Re: [Qemu-devel] [PATCH v3 00/45] hppa-softmmu, no-reply, 2018/01/24