[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v4 43/43] target/hppa: Implement PROBE for system mod
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL v4 43/43] target/hppa: Implement PROBE for system mode |
Date: |
Sun, 28 Jan 2018 15:15:28 -0800 |
Signed-off-by: Richard Henderson <address@hidden>
---
target/hppa/helper.h | 3 +--
target/hppa/op_helper.c | 34 +++++++++++++++++++++++-----------
target/hppa/translate.c | 20 ++++++++++++++++----
3 files changed, 40 insertions(+), 17 deletions(-)
diff --git a/target/hppa/helper.h b/target/hppa/helper.h
index 31320740da..51dc3f8b09 100644
--- a/target/hppa/helper.h
+++ b/target/hppa/helper.h
@@ -17,8 +17,7 @@ DEF_HELPER_FLAGS_3(stby_b_parallel, TCG_CALL_NO_WG, void,
env, tl, tr)
DEF_HELPER_FLAGS_3(stby_e, TCG_CALL_NO_WG, void, env, tl, tr)
DEF_HELPER_FLAGS_3(stby_e_parallel, TCG_CALL_NO_WG, void, env, tl, tr)
-DEF_HELPER_FLAGS_1(probe_r, TCG_CALL_NO_RWG_SE, tr, tl)
-DEF_HELPER_FLAGS_1(probe_w, TCG_CALL_NO_RWG_SE, tr, tl)
+DEF_HELPER_FLAGS_4(probe, TCG_CALL_NO_WG, tr, env, tl, i32, i32)
DEF_HELPER_FLAGS_1(loaded_fr0, TCG_CALL_NO_RWG, void, env)
diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c
index 37160f0d91..4c00d15213 100644
--- a/target/hppa/op_helper.c
+++ b/target/hppa/op_helper.c
@@ -160,21 +160,33 @@ void HELPER(stby_e_parallel)(CPUHPPAState *env,
target_ulong addr,
do_stby_e(env, addr, val, true);
}
-target_ureg HELPER(probe_r)(target_ulong addr)
+target_ureg HELPER(probe)(CPUHPPAState *env, target_ulong addr,
+ uint32_t level, uint32_t want)
{
#ifdef CONFIG_USER_ONLY
- return page_check_range(addr, 1, PAGE_READ);
+ return page_check_range(addr, 1, want);
#else
- return 1; /* FIXME */
-#endif
-}
+ int prot, excp;
+ hwaddr phys;
-target_ureg HELPER(probe_w)(target_ulong addr)
-{
-#ifdef CONFIG_USER_ONLY
- return page_check_range(addr, 1, PAGE_WRITE);
-#else
- return 1; /* FIXME */
+ /* Fail if the requested privilege level is higher than current. */
+ if (level < (env->iaoq_f & 3)) {
+ return 0;
+ }
+
+ excp = hppa_get_physical_address(env, addr, level, 0, &phys, &prot);
+ if (excp >= 0) {
+ if (env->psw & PSW_Q) {
+ /* ??? Needs tweaking for hppa64. */
+ env->cr[CR_IOR] = addr;
+ env->cr[CR_ISR] = addr >> 32;
+ }
+ if (excp == EXCP_DTLB_MISS) {
+ excp = EXCP_NA_DTLB_MISS;
+ }
+ hppa_dynamic_excp(env, excp, GETPC());
+ }
+ return (want & prot) != 0;
#endif
}
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index c62ee72615..7c45b1706c 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -2380,21 +2380,33 @@ static DisasJumpType trans_probe(DisasContext *ctx,
uint32_t insn,
{
unsigned rt = extract32(insn, 0, 5);
unsigned sp = extract32(insn, 14, 2);
+ unsigned rr = extract32(insn, 16, 5);
unsigned rb = extract32(insn, 21, 5);
unsigned is_write = extract32(insn, 6, 1);
+ unsigned is_imm = extract32(insn, 13, 1);
TCGv_reg dest, ofs;
+ TCGv_i32 level, want;
TCGv_tl addr;
nullify_over(ctx);
- /* ??? Do something with priv level operand. */
dest = dest_gpr(ctx, rt);
form_gva(ctx, &addr, &ofs, rb, 0, 0, 0, sp, 0, false);
- if (is_write) {
- gen_helper_probe_w(dest, addr);
+
+ if (is_imm) {
+ level = tcg_const_i32(extract32(insn, 16, 2));
} else {
- gen_helper_probe_r(dest, addr);
+ level = tcg_temp_new_i32();
+ tcg_gen_trunc_reg_i32(level, load_gpr(ctx, rr));
+ tcg_gen_andi_i32(level, level, 3);
}
+ want = tcg_const_i32(is_write ? PROT_WRITE : PROT_READ);
+
+ gen_helper_probe(dest, cpu_env, addr, level, want);
+
+ tcg_temp_free_i32(want);
+ tcg_temp_free_i32(level);
+
save_gpr(ctx, rt, dest);
return nullify_end(ctx, DISAS_NEXT);
}
--
2.14.3
- [Qemu-devel] [PULL v4 33/43] target/hppa: Increase number of temp regs, (continued)
- [Qemu-devel] [PULL v4 33/43] target/hppa: Increase number of temp regs, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 30/43] target/hppa: Add migration for the cpu, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 31/43] target/hppa: Implement B,GATE insn, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 35/43] target/hppa: Implement LDSID for system mode, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 34/43] target/hppa: Fix comment, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 36/43] target/hppa: Implement a pause instruction, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 41/43] hw/hppa: Add MAINTAINERS entry, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 37/43] target/hppa: Implement STWA, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 38/43] target/hppa: Enable MTTCG, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 39/43] hw/hppa: Implement DINO system board, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 43/43] target/hppa: Implement PROBE for system mode,
Richard Henderson <=
- [Qemu-devel] [PULL v4 42/43] target/hppa: Fix 32-bit operand masks for 0E FCVT, Richard Henderson, 2018/01/28
- [Qemu-devel] [PULL v4 40/43] pc-bios: Add hppa-firmware.img and git submodule, Richard Henderson, 2018/01/28
- Re: [Qemu-devel] [PULL v4 00/43] hppa-softmmu, no-reply, 2018/01/28
- Re: [Qemu-devel] [PULL v4 00/43] hppa-softmmu, Peter Maydell, 2018/01/29