Re: [Qemu-devel] [PULL v4 00/43] hppa-softmmu

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL v4 00/43] hppa-softmmu

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0b19f472c3 target/hppa: Implement PROBE for system mode
f8b0dc25e7 target/hppa: Fix 32-bit operand masks for 0E FCVT
4f338e3a6d hw/hppa: Add MAINTAINERS entry
fb2f696c98 pc-bios: Add hppa-firmware.img and git submodule
9e43bbb8a5 hw/hppa: Implement DINO system board
5b5b9114cc target/hppa: Enable MTTCG
63441b4134 target/hppa: Implement STWA
ee78a23ecb target/hppa: Implement a pause instruction
90a52b4abb target/hppa: Implement LDSID for system mode
b014283280 target/hppa: Fix comment
fa466284b5 target/hppa: Increase number of temp regs
20001cfeef target/hppa: Only use EXCP_DTLB_MISS
5b4455c49e target/hppa: Implement B,GATE insn
aec9b0688c target/hppa: Add migration for the cpu
a473d780e8 target/hppa: Add system registers to gdbstub
6928383647 target/hppa: Optimize for flat addressing space
f8f0974b3d target/hppa: Implement halt and reset instructions
092fe10153 target/hppa: Implement SYNCDMA insn
90fd6be65f target/hppa: Implement LCI
7f846dfa32 target/hppa: Implement LPA
2db9459ffc target/hppa: Implement LDWA
fea7bd5c37 target/hppa: Implement P*TLB and P*TLBE insns
da872a7f8d target/hppa: Implement I*TLBA and I*TLBP insns
f6716e5b8b target/hppa: Log unimplemented instructions
e0ac42f050 target/hppa: Implement the interval timer
6d46215e25 target/hppa: Implement external interrupts
37cae384f7 target/hppa: Implement tlb_fill
8354b57ed1 target/hppa: Implement IASQ
79be80eb06 target/hppa: Avoid privilege level decrease during branches
03f3f01cf3 target/hppa: Use space registers in data operations
d2c4455b7b target/hppa: Implement unaligned access trap
6a6de65a9f target/hppa: Fill in hppa_cpu_do_interrupt/hppa_cpu_exec_interrupt
82cc023682 target/hppa: Implement rfi
8e2eaf85ca target/hppa: Adjust insn mask for mfctl, w
d06f8421a6 target/hppa: Add control registers
b95ae90db7 target/hppa: Add space registers
bc6ced6f32 target/hppa: Implement the system mask instructions
fd543d67e4 target/hppa: Implement mmu_idx from IA privilege level
b557da4f50 target/hppa: Split address size from register size
e1056c1c3c target/hppa: Define hardware exception types
1298876acc target/hppa: Disable gateway page emulation for system mode
dd1ce17ef0 target/hppa: Define the rest of the PSW
a9b59cdd7f target/hppa: Skeleton support for hppa-softmmu

=== OUTPUT BEGIN ===
Checking PATCH 1/43: target/hppa: Skeleton support for hppa-softmmu...
Checking PATCH 2/43: target/hppa: Define the rest of the PSW...
Checking PATCH 3/43: target/hppa: Disable gateway page emulation for system 
mode...
Checking PATCH 4/43: target/hppa: Define hardware exception types...
Checking PATCH 5/43: target/hppa: Split address size from register size...
Checking PATCH 6/43: target/hppa: Implement mmu_idx from IA privilege level...
Checking PATCH 7/43: target/hppa: Implement the system mask instructions...
Checking PATCH 8/43: target/hppa: Add space registers...
Checking PATCH 9/43: target/hppa: Add control registers...
Checking PATCH 10/43: target/hppa: Adjust insn mask for mfctl, w...
Checking PATCH 11/43: target/hppa: Implement rfi...
Checking PATCH 12/43: target/hppa: Fill in 
hppa_cpu_do_interrupt/hppa_cpu_exec_interrupt...
Checking PATCH 13/43: target/hppa: Implement unaligned access trap...
Checking PATCH 14/43: target/hppa: Use space registers in data operations...
Checking PATCH 15/43: target/hppa: Avoid privilege level decrease during 
branches...
Checking PATCH 16/43: target/hppa: Implement IASQ...
Checking PATCH 17/43: target/hppa: Implement tlb_fill...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#25: FILE: target/hppa/cpu.h:172:
+    unsigned u : 1;
                ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#26: FILE: target/hppa/cpu.h:173:
+    unsigned t : 1;
                ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#27: FILE: target/hppa/cpu.h:174:
+    unsigned d : 1;
                ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#28: FILE: target/hppa/cpu.h:175:
+    unsigned b : 1;
                ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#29: FILE: target/hppa/cpu.h:176:
+    unsigned page_size : 4;
                        ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#30: FILE: target/hppa/cpu.h:177:
+    unsigned ar_type : 3;
                      ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#31: FILE: target/hppa/cpu.h:178:
+    unsigned ar_pl1 : 2;
                     ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#32: FILE: target/hppa/cpu.h:179:
+    unsigned ar_pl2 : 2;
                     ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#33: FILE: target/hppa/cpu.h:180:
+    unsigned entry_valid : 1;
                          ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#34: FILE: target/hppa/cpu.h:181:
+    unsigned access_id : 16;
                        ^

total: 10 errors, 0 warnings, 252 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 18/43: target/hppa: Implement external interrupts...
Checking PATCH 19/43: target/hppa: Implement the interval timer...
Checking PATCH 20/43: target/hppa: Log unimplemented instructions...
Checking PATCH 21/43: target/hppa: Implement I*TLBA and I*TLBP insns...
Checking PATCH 22/43: target/hppa: Implement P*TLB and P*TLBE insns...
Checking PATCH 23/43: target/hppa: Implement LDWA...
Checking PATCH 24/43: target/hppa: Implement LPA...
Checking PATCH 25/43: target/hppa: Implement LCI...
Checking PATCH 26/43: target/hppa: Implement SYNCDMA insn...
Checking PATCH 27/43: target/hppa: Implement halt and reset instructions...
Checking PATCH 28/43: target/hppa: Optimize for flat addressing space...
Checking PATCH 29/43: target/hppa: Add system registers to gdbstub...
Checking PATCH 30/43: target/hppa: Add migration for the cpu...
Checking PATCH 31/43: target/hppa: Implement B,GATE insn...
Checking PATCH 32/43: target/hppa: Only use EXCP_DTLB_MISS...
Checking PATCH 33/43: target/hppa: Increase number of temp regs...
Checking PATCH 34/43: target/hppa: Fix comment...
Checking PATCH 35/43: target/hppa: Implement LDSID for system mode...
Checking PATCH 36/43: target/hppa: Implement a pause instruction...
Checking PATCH 37/43: target/hppa: Implement STWA...
Checking PATCH 38/43: target/hppa: Enable MTTCG...
Checking PATCH 39/43: hw/hppa: Implement DINO system board...
Checking PATCH 40/43: pc-bios: Add hppa-firmware.img and git submodule...
Checking PATCH 41/43: hw/hppa: Add MAINTAINERS entry...
Checking PATCH 42/43: target/hppa: Fix 32-bit operand masks for 0E FCVT...
Checking PATCH 43/43: target/hppa: Implement PROBE for system mode...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden