Re: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD)

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization 
(AMD)

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
6efcae2888 sev: add migration blocker
16a9e00946 target/i386: clear C-bit when walking SEV guest page table
3b5e4a5a54 sev: add debug encrypt and decrypt commands
9034d072b3 hw: i386: set ram_debug_ops when memory encryption is enabled
9b48370842 sev: Finalize the SEV guest launch flow
5e126818a5 sev: emit the SEV_MEASUREMENT event
1c9a562916 qapi: add SEV_MEASUREMENT event
b322fca554 target/i386: encrypt bios rom
10da3ed830 sev: add command to encrypt guest memory region
cc979f7ffb sev: add command to create launch memory encryption context
9388e9fbf7 hmp: display memory encryption support in 'info kvm'
8875a9eff3 kvm: introduce memory encryption APIs
c530cf3a0f sev: register the guest memory range which may contain encrypted data
f486eda972 sev: add command to initialize the memory encryption context
cd64908627 accel: add Secure Encrypted Virtulization (SEV) object
08729ca7e4 docs: add AMD Secure Encrypted Virtualization (SEV)
e13044a465 kvm: update kvm.h to include memory encryption ioctls
113e16b66e machine: add -memory-encryption property
f839a7f5d1 target/i386: add memory encryption feature cpuid support
4e159e781f monitor/i386: use debug APIs when accessing guest memory
fbeb706e23 exec: add debug version of physical memory read and write API
11bc1372d7 exec: add ram_debug_ops support
1b02df629e memattrs: add debug attribute

=== OUTPUT BEGIN ===
Checking PATCH 1/23: memattrs: add debug attribute...
Checking PATCH 2/23: exec: add ram_debug_ops support...
WARNING: line over 80 characters
#208: FILE: include/exec/memory.h:640:
+ * memory_region_set_ram_debug_ops: Set debug access ops for a given memory 
region

total: 0 errors, 1 warnings, 173 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/23: exec: add debug version of physical memory read and write 
API...
Checking PATCH 4/23: monitor/i386: use debug APIs when accessing guest memory...
WARNING: line over 80 characters
#356: FILE: target/i386/monitor.c:512:
+                        cpu_physical_memory_read_debug(pt_addr + l4 * 8, &pte, 
8);

total: 0 errors, 1 warnings, 291 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/23: target/i386: add memory encryption feature cpuid support...
Checking PATCH 6/23: machine: add -memory-encryption property...
Checking PATCH 7/23: kvm: update kvm.h to include memory encryption ioctls...
Checking PATCH 8/23: docs: add AMD Secure Encrypted Virtualization (SEV)...
Checking PATCH 9/23: accel: add Secure Encrypted Virtulization (SEV) object...
Checking PATCH 10/23: sev: add command to initialize the memory encryption 
context...
Checking PATCH 11/23: sev: register the guest memory range which may contain 
encrypted data...
Checking PATCH 12/23: kvm: introduce memory encryption APIs...
Checking PATCH 13/23: hmp: display memory encryption support in 'info kvm'...
Checking PATCH 14/23: sev: add command to create launch memory encryption 
context...
Checking PATCH 15/23: sev: add command to encrypt guest memory region...
ERROR: space prohibited between function name and open parenthesis '('
#86: FILE: accel/kvm/sev.c:474:
+    assert (handle);

total: 1 errors, 0 warnings, 86 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 16/23: target/i386: encrypt bios rom...
Checking PATCH 17/23: qapi: add SEV_MEASUREMENT event...
Checking PATCH 18/23: sev: emit the SEV_MEASUREMENT event...
Checking PATCH 19/23: sev: Finalize the SEV guest launch flow...
Checking PATCH 20/23: hw: i386: set ram_debug_ops when memory encryption is 
enabled...
Checking PATCH 21/23: sev: add debug encrypt and decrypt commands...
Checking PATCH 22/23: target/i386: clear C-bit when walking SEV guest page 
table...
Checking PATCH 23/23: sev: add migration blocker...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden