Re: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks

[Eric Blake]

ping

On 01/05/2018 04:57 PM, Eric Blake wrote:
> There are patches floating around to add NBD_CMD_BLOCK_STATUS,
> but NBD wants to report status on byte granularity (even if the
> reporting will probably be naturally aligned to sectors or even
> much higher levels).  I've therefore started the task of
> converting our block status code to report at a byte granularity
> rather than sectors.
> 
> These patches have been around for a while, but it's time to
> finish it now that 2.12 is open for patches.
> 
> Based-on: <address@hidden>
> (Kevin's [PULL v3 00/35] Block layer patches)
> 
> The overall conversion currently looks like:
> part 1: bdrv_is_allocated (merged, commit 51b0a488, 2.10)
> part 2: dirty-bitmap (merged, commit ca759622, 2.11)
> part 3: bdrv_get_block_status (merged, commit f0a9c18f, 2.11)
> part 4: .bdrv_co_block_status (this series, v5 was here [1])
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg01246.html
> 
> Available as a tag at:
> git fetch git://repo.or.cz/qemu/ericb.git nbd-byte-callback-v7
> 
> Since v6:
> - add R-bs
> - improve some commit messages, comments, and variable types [Fam]
> - fix conversion bugs [Vladimir]
> - rebase to master (well, Kevin's pull request) [Jeff]
> 
> 001/20:[----] [--] 'block: Add .bdrv_co_block_status() callback'
> 002/20:[----] [--] 'block: Switch passthrough drivers to 
> .bdrv_co_block_status()'
> 003/20:[----] [--] 'file-posix: Switch to .bdrv_co_block_status()'
> 004/20:[----] [--] 'gluster: Switch to .bdrv_co_block_status()'
> 005/20:[----] [--] 'iscsi: Switch cluster_sectors to byte-based'
> 006/20:[0004] [FC] 'iscsi: Switch iscsi_allocmap_update() to byte-based'
> 007/20:[0006] [FC] 'iscsi: Switch to .bdrv_co_block_status()'
> 008/20:[----] [--] 'null: Switch to .bdrv_co_block_status()'
> 009/20:[0002] [FC] 'parallels: Switch to .bdrv_co_block_status()'
> 010/20:[----] [--] 'qcow: Switch to .bdrv_co_block_status()'
> 011/20:[----] [--] 'qcow2: Switch to .bdrv_co_block_status()'
> 012/20:[----] [--] 'qed: Switch to .bdrv_co_block_status()'
> 013/20:[----] [--] 'raw: Switch to .bdrv_co_block_status()'
> 014/20:[0012] [FC] 'sheepdog: Switch to .bdrv_co_block_status()'
> 015/20:[----] [--] 'vdi: Avoid bitrot of debugging code'
> 016/20:[----] [--] 'vdi: Switch to .bdrv_co_block_status()'
> 017/20:[----] [--] 'vmdk: Switch to .bdrv_co_block_status()'
> 018/20:[0002] [FC] 'vpc: Switch to .bdrv_co_block_status()'
> 019/20:[----] [--] 'vvfat: Switch to .bdrv_co_block_status()'
> 020/20:[----] [--] 'block: Drop unused .bdrv_co_get_block_status()'
> 
> Eric Blake (20):
>   block: Add .bdrv_co_block_status() callback
>   block: Switch passthrough drivers to .bdrv_co_block_status()
>   file-posix: Switch to .bdrv_co_block_status()
>   gluster: Switch to .bdrv_co_block_status()
>   iscsi: Switch cluster_sectors to byte-based
>   iscsi: Switch iscsi_allocmap_update() to byte-based
>   iscsi: Switch to .bdrv_co_block_status()
>   null: Switch to .bdrv_co_block_status()
>   parallels: Switch to .bdrv_co_block_status()
>   qcow: Switch to .bdrv_co_block_status()
>   qcow2: Switch to .bdrv_co_block_status()
>   qed: Switch to .bdrv_co_block_status()
>   raw: Switch to .bdrv_co_block_status()
>   sheepdog: Switch to .bdrv_co_block_status()
>   vdi: Avoid bitrot of debugging code
>   vdi: Switch to .bdrv_co_block_status()
>   vmdk: Switch to .bdrv_co_block_status()
>   vpc: Switch to .bdrv_co_block_status()
>   vvfat: Switch to .bdrv_co_block_status()
>   block: Drop unused .bdrv_co_get_block_status()
> 
>  include/block/block.h     |  14 ++---
>  include/block/block_int.h |  51 +++++++++------
>  block/io.c                |  86 +++++++++++--------------
>  block/blkdebug.c          |  20 +++---
>  block/commit.c            |   2 +-
>  block/file-posix.c        |  62 +++++++++---------
>  block/gluster.c           |  70 ++++++++++-----------
>  block/iscsi.c             | 157 
> ++++++++++++++++++++++++----------------------
>  block/mirror.c            |   2 +-
>  block/null.c              |  23 +++----
>  block/parallels.c         |  22 ++++---
>  block/qcow.c              |  27 ++++----
>  block/qcow2.c             |  24 +++----
>  block/qed.c               |  84 +++++++++----------------
>  block/raw-format.c        |  16 ++---
>  block/sheepdog.c          |  26 ++++----
>  block/throttle.c          |   2 +-
>  block/vdi.c               |  45 +++++++------
>  block/vmdk.c              |  38 +++++------
>  block/vpc.c               |  45 ++++++-------
>  block/vvfat.c             |  16 +++--
>  21 files changed, 404 insertions(+), 428 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature