[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/18] Typedef the subtypes of QObject in qemu/t
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/18] Typedef the subtypes of QObject in qemu/typedefs.h, too |
Date: |
Tue, 30 Jan 2018 10:50:09 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/30/2018 04:21 AM, Markus Armbruster wrote:
> This renders many inclusions of qapi/qmp/q*.h superfluous. They'll be
> dropped in the next few commits.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> +++ b/include/qemu/typedefs.h
> @@ -92,8 +92,13 @@ typedef struct QemuOptsList QemuOptsList;
> typedef struct QEMUSGList QEMUSGList;
> typedef struct QEMUTimer QEMUTimer;
> typedef struct QEMUTimerListGroup QEMUTimerListGroup;
> -typedef struct QObject QObject;
> +typedef struct QBool QBool;
> +typedef struct QDict QDict;
> +typedef struct QList QList;
> typedef struct QNull QNull;
> +typedef struct QNum QNum;
> +typedef struct QObject QObject;
And sorting QNull before QOjbect while at it, broken since 4d2d5c41a
(it's appalling how often we break sorting, in spite of a comment
requesting it).
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 01/18] Clean up includes, (continued)
- [Qemu-devel] [PATCH 13/18] Include qapi/qmp/qbool.h exactly where needed, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 17/18] Drop superfluous includes of qapi/qmp/qjson.h, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 08/18] qdict qlist: Make most helper macros functions, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 06/18] Typedef the subtypes of QObject in qemu/typedefs.h, too, Markus Armbruster, 2018/01/30
- Re: [Qemu-devel] [PATCH 06/18] Typedef the subtypes of QObject in qemu/typedefs.h, too,
Eric Blake <=
- [Qemu-devel] [PATCH 18/18] Move include qemu/option.h from qemu-common.h to actual users, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 03/18] Include qapi/error.h exactly where needed, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h, Markus Armbruster, 2018/01/30
- [Qemu-devel] [PATCH 16/18] Drop superfluous includes of qapi/qmp/dispatch.h, Markus Armbruster, 2018/01/30