qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/18] Eliminate qapi/qmp/types.h


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 07/18] Eliminate qapi/qmp/types.h
Date: Tue, 30 Jan 2018 10:56:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 01/30/2018 04:21 AM, Markus Armbruster wrote:
> qapi/qmp/types.h is a convenience header to include a number of
> qapi/qmp/ headers.  Since we rarely need all of the headers
> qapi/qmp/types.h includes, we bypass it most of the time.  Most of the
> places that use it don't need all the headers, either.
> 
> Include the necessary headers directly, and drop qapi/qmp/types.h.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block/qapi.c                        |  3 ++-
>  block/qcow2.c                       |  3 ++-
>  blockdev.c                          |  2 +-
>  hw/pci/pcie_aer.c                   |  1 -
>  hw/watchdog/watchdog.c              |  1 -
>  include/qapi/qmp/types.h            | 24 ------------------------

Goodbye!  Glad to be rid of you!

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]