Re: [Qemu-devel] [PULL v5 00/43] hppa-softmmu

[Peter Maydell]

On 30 January 2018 at 04:46, Richard Henderson
<address@hidden> wrote:
> Changes since v4:
>   * Fix format warnings for 32-bit host.
>
>
> r~
>
>
> The following changes since commit 30d9fefe1aca1e92c785214aa9201fd7c2287d56:
>
>   Merge remote-tracking branch 
> 'remotes/kraxel/tags/input-20180129-v2-pull-request' into staging (2018-01-29 
> 15:52:27 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/rth7680/qemu.git tags/pull-hppa-20180129
>
> for you to fetch changes up to 8d077702ca076c0264e111b95c2c211e5ab9a314:
>
>   target/hppa: Implement PROBE for system mode (2018-01-29 20:40:01 -0800)
>
> ----------------------------------------------------------------
> Implement hppa-softmmu
>
> ----------------------------------------------------------------

The Windows build fails:

/home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c: In
function ‘gen_hlt’:
/home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:2336:9:
error: implicit declaration of function ‘gen_helper_shutdown’
[-Werror=implicit-function-declaration]
         gen_helper_shutdown(cpu_env);
         ^
/home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:2336:9:
error: nested extern declaration of ‘gen_helper_shutdown’
[-Werror=nested-externs]

I think here you're falling foul of this thing in include/win32/os-win32.h:

#define shutdown qemu_shutdown_wrap

which messes up the use in the HELPER macro.


/home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c: In
function ‘trans_probe’:
/home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:2403:37:
error: ‘PROT_WRITE’ undeclared (first use in this function)
     want = tcg_const_i32(is_write ? PROT_WRITE : PROT_READ);
                                     ^
/home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:2403:37:
note: each undeclared identifier is reported only once for each
function it appears in
/home/petmay01/linaro/qemu-for-merges/target/hppa/translate.c:2403:50:
error: ‘PROT_READ’ undeclared (first use in this function)
     want = tcg_const_i32(is_write ? PROT_WRITE : PROT_READ);
                                                  ^
cc1: all warnings being treated as errors

I'm guessing you wanted PAGE_READ and PAGE_WRITE.

thanks
-- PMM