Re: [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address for APP CMD (CMD55)

[Alistair Francis]

On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé <address@hidden> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Alistair Francis <address@hidden>

Alistair

> ---
>  hw/sd/sd.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 434d1fbc47..b5c947df62 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1394,6 +1394,11 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, 
> SDRequest req)
>          case sd_identification_state:
>          case sd_inactive_state:
>              return sd_illegal;
> +        case sd_idle_state:
> +            if (rca) {
> +                qemu_log_mask(LOG_GUEST_ERROR,
> +                              "SD: illegal RCA 0x%04x for APP_CMD\n", 
> req.cmd);
> +            }
>          default:
>              break;
>          }
> --
> 2.15.1
>
>