[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address for APP CMD (CMD55) |
Date: |
Wed, 31 Jan 2018 16:27:56 -0800 |
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé <address@hidden> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/sd/sd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 434d1fbc47..b5c947df62 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1394,6 +1394,11 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
> SDRequest req)
> case sd_identification_state:
> case sd_inactive_state:
> return sd_illegal;
> + case sd_idle_state:
> + if (rca) {
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "SD: illegal RCA 0x%04x for APP_CMD\n",
> req.cmd);
> + }
> default:
> break;
> }
> --
> 2.15.1
>
>
- [Qemu-devel] [PATCH v3 07/18] sdcard: use the correct masked OCR in the R3 reply, (continued)
- [Qemu-devel] [PATCH v3 07/18] sdcard: use the correct masked OCR in the R3 reply, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 08/18] sdcard: use the registerfields API for the CARD_STATUS register masks, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 09/18] sdcard: handles more commands in SPI mode, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 10/18] sdcard: handle CMD54 (SDIO), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 11/18] sdcard: check the card is in correct state for APP CMD (CMD55), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address for APP CMD (CMD55), Philippe Mathieu-Daudé, 2018/01/22
- Re: [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address for APP CMD (CMD55),
Alistair Francis <=
- [Qemu-devel] [PATCH v3 13/18] sdcard: simplify SEND_IF_COND (CMD8), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 14/18] sdcard: simplify SD_SEND_OP_COND (ACMD41), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 15/18] sdcard: add SD SEND_TUNING_BLOCK (CMD19), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 16/18] sdcard: add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit, Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 17/18] sdcard: implement the UHS-I SWITCH_FUNCTION entries (Spec v3), Philippe Mathieu-Daudé, 2018/01/22
- [Qemu-devel] [PATCH v3 18/18] sdcard: add an enum for the SD PHY Spec version, Philippe Mathieu-Daudé, 2018/01/22