[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes |
Date: |
Thu, 1 Feb 2018 10:27:37 +0800 |
On Wed, Jan 31, 2018 at 11:48 PM, Thomas Huth <address@hidden> wrote:
> On 31.01.2018 15:48, Markus Armbruster wrote:
>> Clean up includes so that osdep.h is included first and headers
>> which it implies are not included manually.
>>
>> This commit was created with scripts/clean-includes, with the change
>> to target/s390x/gen-features.c manually reverted, and blank lines
>> around deletions collapsed.
>
> Reviewed-by: Thomas Huth <address@hidden>
>
> I wonder whether it would make sense to add a check based on
> scripts/clean-includes to patchew already, so that these includes do not
> sneak in so easily again...?
(Having not looked at the series), are we clean with this series
applied? If so it makes a good point to do so.
Fam
>
> Thomas
- [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others, (continued)
- [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 10/19] Include qapi/qmp/qobject.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 16/19] Include qapi/qmp/qnull.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 03/19] Drop superfluous includes of qapi-types.h and test-qapi-types.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 02/19] Clean up includes, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 07/19] Typedef the subtypes of QObject in qemu/typedefs.h, too, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 06/19] Include qmp-commands.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 17/19] Drop superfluous includes of qapi/qmp/dispatch.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 13/19] Include qapi/qmp/qstring.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 05/19] Drop superfluous includes of qapi/qmp/qerror.h, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 09/19] qdict qlist: Make most helper macros functions, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 12/19] Include qapi/qmp/qdict.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 14/19] Include qapi/qmp/qbool.h exactly where needed, Markus Armbruster, 2018/01/31
- [Qemu-devel] [PATCH v2 04/19] Include qapi/error.h exactly where needed, Markus Armbruster, 2018/01/31