qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] tracetool: Fix ust tracepoint issues


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 0/2] tracetool: Fix ust tracepoint issues
Date: Thu, 1 Feb 2018 13:34:34 +0000
User-agent: Mutt/1.9.1 (2017-09-22)

On Mon, Jan 29, 2018 at 05:16:46AM +0100, Jon Emil Jahren wrote:
> There are some issues with the argument parsing for ust.
> The first issue is that the regex pattern matching arguments with PRI
> types matched too much. This was fixed by using a non-greedy star,
> instead of a greedy.
> The second issue is that bool type is not recognized. This was fixed by
> adding the bool type to be traced as an integer.
> Both issues causes missing information in the trace.
> 
> The following patches fix the issues mentioned.
> 
> Jon Emil Jahren (2):
>   tracetool: Update argument format regex to non-greedy star
>   tracetool: For ust trace bool type as ctf_integer
> 
>  scripts/tracetool/__init__.py            | 5 +++--
>  scripts/tracetool/format/ust_events_h.py | 3 ++-
>  2 files changed, 5 insertions(+), 3 deletions(-)

Excellent work, thanks for the patches!

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]