[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spapr: add missing break in h_get_cpu_character
From: |
Suraj Jitindar Singh |
Subject: |
Re: [Qemu-devel] [PATCH] spapr: add missing break in h_get_cpu_characteristics() |
Date: |
Fri, 02 Feb 2018 15:31:30 +1100 |
On Thu, 2018-02-01 at 20:47 +0100, Greg Kurz wrote:
> Detected by Coverity (CID 1385702). This fixes the recently added
> hypercall
> to let guests properly apply Spectre and Meltdown workarounds.
>
> Fixes: c59704b25473 "target/ppc/spapr: Add H-Call
> H_GET_CPU_CHARACTERISTICS"
> Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Suraj Jitindar Singh <address@hidden>
> ---
> hw/ppc/spapr_hcall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 4d0e6eb0cf1d..596f58378a40 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1697,6 +1697,7 @@ static target_ulong
> h_get_cpu_characteristics(PowerPCCPU *cpu,
> switch (safe_indirect_branch) {
> case SPAPR_CAP_FIXED:
> characteristics |= H_CPU_CHAR_BCCTRL_SERIALISED;
> + break;
> default: /* broken */
> assert(safe_indirect_branch == SPAPR_CAP_BROKEN);
> break;
>