qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 11/12] vl: drop request_opengl variable


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 11/12] vl: drop request_opengl variable
Date: Fri, 2 Feb 2018 10:06:40 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/02/2018 05:10 AM, Gerd Hoffmann wrote:
> Switch over the one leftover user to qapi DisplayType.
> The delete the unused request_opengl variable.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  vl.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 

>  
> -    if (request_opengl == 1 && display_opengl == 0) {
> +    if (dpy.has_gl && dpy.gl && display_opengl == 0) {
>  #if defined(CONFIG_OPENGL)
>          error_report("OpenGL is not supported by the display");
>  #else

Maybe someday when QAPI supports conditionals we can make the exposure
of the 'gl' field guarded by those conditionals, for better
introspection, rather than the current series' approach of always
exposing it then failing at runtime.  But that doesn't hold up this series.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]