Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

[Fam Zheng]

On Thu, Feb 1, 2018 at 6:46 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote:
>> Hi
>>
>> On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng <address@hidden> wrote:
>> > git-publish [1] is a convenient tool to send patches and has been
>> > popular among QEMU developers.  Recently it has been made available in
>> > Fedora official repo thanks to Stefan's work.
>> >
>> > One nice feature of the tool is a per-project configuration with
>> > profiles, especially in which the cccmd option is a handy method to
>> > create the Cc list.
>> >
>> > [1]: https://github.com/stefanha/git-publish
>>
>> It would be worth to update README "Submitting patches" with an example
>
> Good idea!
>
> The workflow for a new patch series is:
>
>   $ git checkout -b my-feature
>   ...work on feature...
>   $ git publish
>
> Your patch series has been tagged as my-feature-v1 if you need to refer
> back to it in the future.
>
> Sending v2:
>
>   $ git checkout my-feature # same topic branch
>   ...work on feature...
>   $ git publish
>
> Your patch series has been tagged as my-feature-v2.

Will add a paragraph in README.

>
>> >
>> > Signed-off-by: Fam Zheng <address@hidden>
>> > ---
>> >  .gitpublish | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >  1 file changed, 57 insertions(+)
>> >  create mode 100644 .gitpublish
>> >
>> > diff --git a/.gitpublish b/.gitpublish
>> > new file mode 100644
>> > index 0000000000..2099c1520f
>> > --- /dev/null
>> > +++ b/.gitpublish
>> > @@ -0,0 +1,57 @@
>> > +#
>> > +# Common git-publish profiles that can be used to send patches to QEMU 
>> > upstream.
>> > +#
>> > +# See https://github.com/stefanha/git-publish for more information
>> > +#
>> > +[gitpublishprofile "qemu"]
>
> Please rename the "qemu" profile to "default".  This way no --profile
> needs to be given:
>
>   $ git publish
>
> The default profile settings can be overridden by command-line options
> and branch-specific settings.

Yes, good idea.

Fam