[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] ui: correctly advance output buffer when wri
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v1] ui: correctly advance output buffer when writing SASL data |
Date: |
Fri, 2 Feb 2018 07:49:44 +0100 |
User-agent: |
NeoMutt/20171215 |
On Thu, Feb 01, 2018 at 10:03:23AM -0600, Eric Blake wrote:
> On 02/01/2018 09:58 AM, Daniel P. Berrangé wrote:
> > In this previous commit:
> >
> > commit 8f61f1c5a6bc06438a1172efa80bc7606594fa07
> > Author: Daniel P. Berrange <address@hidden>
> > Date: Mon Dec 18 19:12:20 2017 +0000
> >
> > ui: track how much decoded data we consumed when doing SASL encoding
> >
> > I attempted to fix a flaw with tracking how much data had actually been
> > processed when encoding with SASL. With that flaw, the VNC server could
> > mistakenly discard queued data that had not been sent.
> >
> > The fix was not quite right though, because it merely decremented the
> > vs->output.offset value. This is effectively to discarding data from the
>
> s/to //
Patch queued, fix applied.
thanks,
Gerd