Re: [Qemu-devel] [PATCH v7 02/15] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 02/02/2018 12:37 PM, Markus Armbruster wrote:
>> From: Alistair Francis <address@hidden>
>> 
>> Replace a large number of the fprintf(stderr, "*\n" calls with
>> error_report(). The functions were renamed with these commands and then
>> compiler issues where manually fixed.
>> 
>
>> 
>> Some lines where then manually tweaked to pass checkpatch.
>> 
>> The 'qemu: ' prefix was manually removed from the hw/arm/boot.c file.
>> 
>> Signed-off-by: Alistair Francis <address@hidden>
>> Cc: address@hidden
>> 
>> Conversions that aren't followed by exit() dropped, because they might
>> be inappropriate.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>
>> +++ b/hw/arm/gumstix.c
>> @@ -35,6 +35,7 @@
>>   */
>>  
>>  #include "qemu/osdep.h"
>> +#include "qemu/error-report.h"
>>  #include "hw/hw.h"
>>  #include "hw/arm/pxa.h"
>>  #include "net/net.h"
>> @@ -62,8 +63,8 @@ static void connex_init(MachineState *machine)
>>  
>>      dinfo = drive_get(IF_PFLASH, 0, 0);
>>      if (!dinfo && !qtest_enabled()) {
>> -        fprintf(stderr, "A flash image must be given with the "
>> -                "'pflash' parameter\n");
>> +        error_report("A flash image must be given with the "
>> +                     "'pflash' parameter");
>>          exit(1);
>>      }
>>  
>> @@ -76,7 +77,7 @@ static void connex_init(MachineState *machine)
>>                                 dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
>>                                 sector_len, connex_rom / sector_len,
>>                                 2, 0, 0, 0, 0, be)) {
>> -        fprintf(stderr, "qemu: Error registering flash memory.\n");
>> +        error_report("Error registering flash memory.");
>
> Do we care about consistency on trailing dots in these conversions?

Good opportunity to get rid of trailing punctuation in converted error
messages.

> At any rate, all of these are sane rewrites of existing patterns;
> Reviewed-by: Eric Blake <address@hidden>

Thanks!