Re: [Qemu-devel] [PATCH 1/3] tests/boot-serial: Enable the boot-serial test on SPARC machines, too

[Mark Cave-Ayland]

On 01/02/18 10:09, Thomas Huth wrote:
> OpenBIOS prints out the name of the detected CPU here, so looking for
> this string is a nice test to verify that the CPU detection is still
> working correctly.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>   tests/Makefile.include   | 2 ++
>   tests/boot-serial-test.c | 4 ++++
>   2 files changed, 6 insertions(+)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index ca82e0c..0b98dd7 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -350,11 +350,13 @@ check-qtest-sh4eb-y = tests/endianness-test$(EXESUF)
>   check-qtest-sparc-y = tests/prom-env-test$(EXESUF)
>   #check-qtest-sparc-y += tests/m48t59-test$(EXESUF)
>   #gcov-files-sparc-y = hw/timer/m48t59.c
> +check-qtest-sparc-y += tests/boot-serial-test$(EXESUF)
>   
>   check-qtest-sparc64-y = tests/endianness-test$(EXESUF)
>   #check-qtest-sparc64-y += tests/m48t59-test$(EXESUF)
>   #gcov-files-sparc64-y += hw/timer/m48t59.c
>   check-qtest-sparc64-y += tests/prom-env-test$(EXESUF)
> +check-qtest-sparc64-y += tests/boot-serial-test$(EXESUF)
>   
>   check-qtest-arm-y = tests/tmp105-test$(EXESUF)
>   check-qtest-arm-y += tests/ds1338-test$(EXESUF)
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index 418c5b9..abc7f2d 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -78,6 +78,10 @@ static testdef_t tests[] = {
>       { "i386", "q35", "-device sga", "SGABIOS" },
>       { "x86_64", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
>       { "x86_64", "q35", "-device sga", "SGABIOS" },
> +    { "sparc", "LX", "", "TMS390S10" },
> +    { "sparc", "SS-4", "", "MB86904" },
> +    { "sparc", "SS-600MP", "", "TMS390Z55" },
> +    { "sparc64", "sun4u", "", "UltraSPARC" },
>       { "s390x", "s390-ccw-virtio",
>         "-nodefaults -device sclpconsole,chardev=serial0", "virtio device" },
>       { "m68k", "mcf5208evb", "", "TT", sizeof(kernel_mcf5208), kernel_mcf5208 
> },

Why not?

Acked-by: Mark Cave-Ayland <address@hidden>


ATB,

Mark.