Re: [Qemu-devel] [PATCH RFC 02/21] qapi: Generate up-to-date copyright notice

[Markus Armbruster]

Marc-Andre Lureau <address@hidden> writes:

> Hi
>
> On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <address@hidden> wrote:
>> Each generator carries a copyright notice for the generator itself,
>> and another one for the files it generates.  Only the former have been
>> updated along the way, the latter have not, and are all out of date.
>>
>> Fix by copying the generator's copyright notice to the generated files
>> instead.
>
> That makes sense, but we loose the Author lines in the generated
> files. Not a big deal I guess, but worth to point out, no?

We do.  They've become just as outdated as the copyright notices.
Giving them the same treatment doesn't seem to be worth the trouble.
I'm happy to explain this in the commit message.

>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Other than that,
> Reviewed-by: Marc-André Lureau <address@hidden>

Thanks!