[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/9] char: don't silently skip tn3270 protoco
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled |
Date: |
Mon, 5 Feb 2018 17:10:27 +0100 |
On Mon, 5 Feb 2018 15:24:47 +0000
Daniel P. Berrangé <address@hidden> wrote:
> From: "Daniel P. Berrange" <address@hidden>
>
> Even if common tn3270 implementations do not support TLS, it is trivial to
> have them proxied over a proxy like stunnel which adds TLS at the sockets
> layer. We should thus not silently skip tn3270 protocol initialization
> when TLS is enabled.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> chardev/char-socket.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index 77cdf487eb..5c46a89200 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -634,8 +634,7 @@ static void tcp_chr_tls_handshake(QIOTask *task,
> if (qio_task_propagate_error(task, NULL)) {
> tcp_chr_disconnect(chr);
> } else {
> - /* tn3270 does not support TLS yet */
> - if (s->do_telnetopt && !s->is_tn3270) {
> + if (s->do_telnetopt) {
> tcp_chr_telnet_init(chr);
> } else {
> tcp_chr_connect(chr);
Acked-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PATCH v4 0/9] Enable passing pre-opened chardev socket FD, Daniel P . Berrangé, 2018/02/05
- [Qemu-devel] [PATCH v4 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled, Daniel P . Berrangé, 2018/02/05
- Re: [Qemu-devel] [PATCH v4 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled,
Cornelia Huck <=
- [Qemu-devel] [PATCH v4 2/9] cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types, Daniel P . Berrangé, 2018/02/05
- [Qemu-devel] [PATCH v4 4/9] sockets: strengthen test suite IP protocol availability checks, Daniel P . Berrangé, 2018/02/05
- [Qemu-devel] [PATCH v4 3/9] sockets: pull code for testing IP availability out of specific test, Daniel P . Berrangé, 2018/02/05
- [Qemu-devel] [PATCH v4 6/9] sockets: check that the named file descriptor is a socket, Daniel P . Berrangé, 2018/02/05
- [Qemu-devel] [PATCH v4 5/9] sockets: move fd_is_socket() into common sockets code, Daniel P . Berrangé, 2018/02/05
- [Qemu-devel] [PATCH v4 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors, Daniel P . Berrangé, 2018/02/05