[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 41/51] qapi: add -i/--include filename.h
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 41/51] qapi: add -i/--include filename.h |
|
Date: |
Mon, 05 Feb 2018 17:58:49 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Add a new option to add user-specified #include lines in the generated
> headers. This will help to split a schema, where one generated header
> will depend on another.
>
> Fix some pycodestyle on the way.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
With my alternative way to split up the generated monolith[*], required
generated headers should be included without the user's help.
We might conceivably need an ability to add includes for other purposes.
As far as I can tell, this is not the case in your series.
If we need the ability, then I'd rather use a directive in the schema
than a command line option.
[*] [PATCH RFC 00/21] Modularize generated QAPI code
Message-Id: <address@hidden>
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 41/51] qapi: add -i/--include filename.h,
Markus Armbruster <=