Re: [Qemu-devel] [PATCH] linux-user: Implement copy_file_range

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] linux-user: Implement copy_file_range

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5741abe09e linux-user: Implement copy_file_range

=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: Implement copy_file_range...
WARNING: architecture specific defines should be avoided
#19: FILE: linux-user/syscall.c:1036:
+#if defined(TARGET_NR_copy_file_range) && defined(__NR_copy_file_range)

WARNING: architecture specific defines should be avoided
#32: FILE: linux-user/syscall.c:12578:
+#if defined(TARGET_NR_copy_file_range) && defined(__NR_copy_file_range)

ERROR: space prohibited between function name and open parenthesis '('
#50: FILE: linux-user/syscall.c:12596:
+            ret = get_errno (safe_copy_file_range (arg1, pinoff, arg3, poutoff,

ERROR: space prohibited between function name and open parenthesis '('
#50: FILE: linux-user/syscall.c:12596:
+            ret = get_errno (safe_copy_file_range (arg1, pinoff, arg3, poutoff,

total: 2 errors, 2 warnings, 51 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden