[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Recover block devices if failure in
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH] migration: Recover block devices if failure in device state |
Date: |
Tue, 6 Feb 2018 16:15:28 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Feb 05, 2018 at 09:39:41AM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> In e91d895 I added the new pause-before-switchover mechanism
> to allow migration completion to be delayed; this changes the
> last state prior to completion to MIGRATE_STATUS_DEVICE rather
> than MIGRATE_STATUS_ACTIVE.
>
> Fix the failure path in migration_completion to recover the block
> devices if it fails in MIGRATE_STATUS_DEVICE, not just the
> MIGRATE_STATUS_ACTIVE that it previously had.
>
> This corresponds to rh bz:
> https://bugzilla.redhat.com/show_bug.cgi?id=1538494
> whose symptom is an occasional source crash on a failed migration.
>
> Fixes: e91d8951d59d483f085f
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
--
Peter Xu