Re: [Qemu-devel] [PATCH] m68k: implement movep instruction

[Laurent Vivier]

Le 06/02/2018 à 11:06, address@hidden a écrit :
...
>   CC      m68k-softmmu/target/m68k/translate.o
> /var/tmp/patchew-tester-tmp-87qny0g5/src/target/m68k/translate.c: In function 
> ‘disas_movep’:
> /var/tmp/patchew-tester-tmp-87qny0g5/src/target/m68k/translate.c:2110:13: 
> error: too few arguments to function ‘gen_store’
>              gen_store(s, OS_BYTE, abuf, dbuf);
>              ^~~~~~~~~
> /var/tmp/patchew-tester-tmp-87qny0g5/src/target/m68k/translate.c:315:20: 
> note: declared here
>  static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv 
> val,
>                     ^~~~~~~~~
> /var/tmp/patchew-tester-tmp-87qny0g5/src/target/m68k/translate.c:2118:20: 
> error: too few arguments to function ‘gen_load’
>              dbuf = gen_load(s, OS_BYTE, abuf, 1);
>                     ^~~~~~~~
> /var/tmp/patchew-tester-tmp-87qny0g5/src/target/m68k/translate.c:287:20: 
> note: declared here
>  static inline TCGv gen_load(DisasContext *s, int opsize, TCGv addr,
>                     ^~~~~~~~

My last series has added the index parameter to gen_load() and gen_store().

See

commit 54e1e0b5b5ce4fc76335b1fbbf09cb8fdd5ab89d
Author: Laurent Vivier <address@hidden>
Date:   Thu Jan 18 20:38:43 2018 +0100

    target/m68k: add index parameter to gen_load()/gen_store() and Co.

    The instruction "moves" can select source and destination
    address space (user or kernel). This patch modifies
    all the load/store functions to be able to provide
    the address space the caller wants to use instead
    of using the current one. All the callers are modified
    to provide the default address space to these functions.

You need to add "IS_USER(s)" to your calls.

Thanks,
Laurent