[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime opt
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime options |
Date: |
Tue, 06 Feb 2018 15:03:52 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 05 Feb 2018 04:18:29 PM CET, Max Reitz wrote:
> Instead of having every block driver which implements
> bdrv_refresh_filename() copy all of the significant runtime options over
> to bs->full_open_options, implement this process generically in
> bdrv_refresh_filename().
>
> This patch only adds this new generic implementation, it does not remove
> the old functionality. This is done in a follow-up patch.
>
> With this patch, some superfluous information (that should never have
> been there) may be removed from some JSON filenames, as can be seen in
> the change to iotest 110's reference output. In case of 191, backing
> nodes that have not been overridden are now removed from the filename.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-devel] [PATCH v8 10/26] block: Fix bdrv_find_backing_image(), (continued)
- [Qemu-devel] [PATCH v8 10/26] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 11/26] block: Add bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 13/26] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 16/26] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 19/26] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 17/26] iotests: Add quorum case to test 110, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime options, Max Reitz, 2018/02/05
- Re: [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime options,
Alberto Garcia <=
- [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Max Reitz, 2018/02/05
- Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Eric Blake, 2018/02/06
[Qemu-devel] [PATCH v8 24/26] block/curl: Harmonize option defaults, Max Reitz, 2018/02/05