[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename()
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename() |
Date: |
Tue, 06 Feb 2018 15:50:16 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 05 Feb 2018 04:18:30 PM CET, Max Reitz wrote:
> Currently, BlockDriver.bdrv_refresh_filename() is supposed to both
> refresh the filename (BDS.exact_filename) and set BDS.full_open_options.
> Now that we have generic code in the central bdrv_refresh_filename() for
> creating BDS.full_open_options, we can drop the latter part from all
> BlockDriver.bdrv_refresh_filename() implementations.
>
> This also means that we can drop all of the existing default code for
> this from the global bdrv_refresh_filename() itself.
>
> Furthermore, we now have to call BlockDriver.bdrv_refresh_filename()
> after having set BDS.full_open_options, because the block driver's
> implementation should now be allowed to depend on BDS.full_open_options
> being set correctly.
>
> Finally, with this patch we can drop the @options parameter from
> BlockDriver.bdrv_refresh_filename(); also, add a comment on this
> function's purpose in block/block_int.h while touching its interface.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-devel] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, (continued)
- [Qemu-devel] [PATCH v8 12/26] blkverify: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 13/26] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 15/26] block/nfs: Implement bdrv_dirname(), Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 14/26] block/nbd: Make bdrv_dirname() return NULL, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 16/26] block: Use bdrv_dirname() for relative filenames, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 19/26] block: Add BlockDriver.bdrv_gather_child_options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 17/26] iotests: Add quorum case to test 110, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 20/26] block: Generically refresh runtime options, Max Reitz, 2018/02/05
- [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename(), Max Reitz, 2018/02/05
- Re: [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename(),
Alberto Garcia <=
- [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Max Reitz, 2018/02/05
- Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver, Eric Blake, 2018/02/06
[Qemu-devel] [PATCH v8 24/26] block/curl: Harmonize option defaults, Max Reitz, 2018/02/05
[Qemu-devel] [PATCH v8 23/26] block: Fix FIXME from "Add BDS.backing_overridden", Max Reitz, 2018/02/05