[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: include original filename when reporting

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] block: include original filename when reporting invalid URIs
Date: Tue, 6 Feb 2018 09:09:40 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/06/2018 04:52 AM, Daniel P. Berrangé wrote:
Consider passing a JSON based block driver to "qemu-img commit"

$ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\

Currently it will commit the content and then report an incredibly
useless error message when trying to re-open the committed image:

   qemu-img: invalid URI

With this fix we get:

   qemu-img: invalid URI json:{"server.0.host": "",
       "driver": "gluster", "path": "luks.qcow2", "server.0.type":
       "tcp", "server.0.port": "24007", "volume": "gv0"}

Of course the root cause problem still exists, but now we know
what actually needs fixing.

Signed-off-by: Daniel P. Berrangé <address@hidden>
  block/gluster.c  | 2 +-
  block/sheepdog.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]