[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] iotests: 205: support luks format

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] iotests: 205: support luks format
Date: Tue, 6 Feb 2018 12:04:19 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/06/2018 11:57 AM, Vladimir Sementsov-Ogievskiy wrote:

+luks_default_secret_id = 'luks_secret_default_iotests_id'
Can we just call this  "keysec0", so we matchh convention used by
the shell script based tests.

Here I'm trying to avoid intersection with some user-defined id.

You're overthinking it. We are only using this in the testsuite, and nothing else in the testsuite is using 'keysec0' for anything except the id of the secret to pass to encrypted disks. The longer name doesn't add any protection. It might be different if we were trying to provide a reusable library for contexts outside the testsuite, but since we are not doing that, we can rely on 'make check' failing as evidence if we have any collisions in naming choices that need long name munging as a workaround.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]