Re: [Qemu-devel] [PATCH v7 13/26] qmp: add query-sev command

[Eric Blake]

On 02/07/2018 10:06 AM, Brijesh Singh wrote:
> The QMP query command can used to retrieve the SEV information when
> memory encryption is enabled on AMD platform.
>
> Cc: "Daniel P. Berrangé" <address@hidden>
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Brijesh Singh <address@hidden>
> ---

> +##
> +# @SevInfo:
> +#
> +# Information about SEV support
> +#
> +# @enabled: true if SEV is active
> +#
> +# @api_major: SEV API major version

New QMP structures should prefer '-' over '_'; this should be 'api-major'.

> +#
> +# @api_minor: SEV API minor version
> +#
> +# @build_id: SEV FW build id

and so on.

> +#
> +# @policy: SEV policy value
> +#
> +# @state: SEV guest state
> +#
> +# Since: 2.12
> +##
> +{ 'struct': 'SevInfo',
> +    'data': { 'enabled': 'bool',
> +              'api_major': 'uint8',
> +              'api_minor' : 'uint8',
> +              'build_id' : 'uint8',
> +              'policy' : 'uint32',
> +              'state' : 'str'
> +            }
> +}
> +
> +##
> +# @query-sev:
> +#
> +# Returns information about SEV

It would be worth expanding the acronym here, for someone that is 
reading the documentation but not familiar with the term.

> +#
> +# Returns: @SevInfo
> +#
> +# Since: 2.12
> +#
> +# Example:
> +#
> +# -> { "execute": "query-sev" }
> +# <- { "return": { "enabled": true, "api-major" : 0, "api-minor" : 0,
> +#                  "build-id" : 0, "policy" : 0, "state" : "running" } }

This example does not match the spelling you used in the struct above, 
but DOES match what the spelling should be.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org