Re: [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue

[Eric Blake]

On 02/07/2018 11:50 AM, Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
>   qapi-schema.json | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 82d6f12b53..0665a14dba 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -526,6 +526,10 @@
>   #
>   # Returns a list of information about each virtual CPU.
>   #
> +# WARNING: This command incurs a performance penalty for latency
> +#          sensitive workloads and hence it's not recommended to
> +#          to be used in production. Use query-cpus-fast instead
> +#

Ah, I asked for this on 1/2.  You could squash these.

I didn't review the code, just the interface, so if you squash them, you 
can add the weaker:

Acked-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org