[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash informatio

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information
Date: Wed, 7 Feb 2018 13:11:43 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/07/2018 12:44 PM, Christian Borntraeger wrote:

+        } else if (info->type == GUEST_PANIC_INFORMATION_TYPE_S390) {
+            qemu_log_mask(LOG_GUEST_ERROR, " on cpu %d: %s\n"
+                          "PSW: 0x%016" PRIx64 " 0x%016" PRIx64"\n",
+                          info->u.s390.core,
+                          qapi_enum_lookup(&S390CrashReason_lookup,
+                                           info->u.s390.reason),

Question for the qapi people. Would you prefer S390CrashReason_str instead?

Yes, S390CrashReason_str(info->u.s390.reason) is a more legible way to spell this same lookup, and leaves the door open if we later change how the internal &S390CrashReason_lookup[] behaves.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]