qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test


From: Roman Kagan
Subject: Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test
Date: Wed, 7 Feb 2018 22:40:15 +0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Wed, Feb 07, 2018 at 12:15:50PM +0100, Paolo Bonzini wrote:
> On 06/02/2018 21:30, Roman Kagan wrote:
> > +    if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) {
> > +        g_printerr("Hyper-V / VMBus are only available on x86\n");
> > +        exit(EXIT_FAILURE);
> > +    }
> 
> This shouldn't be needed.
> 
> > +
> > +    if (access("/dev/kvm", R_OK | W_OK)) {
> 
> Maybe try opening it too?  In theory you could have a /dev/kvm device
> that triggers loading the kvm module (see
> https://github.com/systemd/systemd/pull/7795 for gory details).

Makes sense, will replace with open(O_RDWR).

Thanks,
Roman.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]