[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test
From: |
Roman Kagan |
Subject: |
Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test |
Date: |
Wed, 7 Feb 2018 22:40:15 +0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, Feb 07, 2018 at 12:15:50PM +0100, Paolo Bonzini wrote:
> On 06/02/2018 21:30, Roman Kagan wrote:
> > + if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) {
> > + g_printerr("Hyper-V / VMBus are only available on x86\n");
> > + exit(EXIT_FAILURE);
> > + }
>
> This shouldn't be needed.
>
> > +
> > + if (access("/dev/kvm", R_OK | W_OK)) {
>
> Maybe try opening it too? In theory you could have a /dev/kvm device
> that triggers loading the kvm module (see
> https://github.com/systemd/systemd/pull/7795 for gory details).
Makes sense, will replace with open(O_RDWR).
Thanks,
Roman.
- [Qemu-devel] [RFC PATCH 26/34] hv-scsi: limit the number of requests per notification, (continued)
- [Qemu-devel] [RFC PATCH 26/34] hv-scsi: limit the number of requests per notification, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 24/34] scsi: add Hyper-V/VMBus SCSI protocol definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 20/34] vmbus: vmbus implementation, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 28/34] net: add RNDIS definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 31/34] hv-net: add .bootindex support, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for fw_cfg file roms, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 30/34] net: add Hyper-V/VMBus net adapter, Roman Kagan, 2018/02/06