[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement |
Date: |
Thu, 8 Feb 2018 13:01:26 +0000 |
On 8 February 2018 at 12:15, Philippe Mathieu-Daudé <address@hidden> wrote:
> Hi Daniel,
>
> On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote:
>> This patch adds a break in the switch() statement of complete(),
>> value 0x42:
>>
>> case 0x42: /* FT2 sets output freq with this, go figure */
>> qemu_log_mask(LOG_UNIMP, "cmd 0x42 might not do what it think it"
>> " should\n");
>> break; <-------
>> case 0x41:
>
> It seems this is an intentional fallthrough, I understand cmd 0x42 is
> expected to do the same of 0x41 and _a bit more_ (see commit 85571bc7415).
Yes, I agree; I wrote a bit about this in this thread:
https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02081.html
(though my guess is that actually 0x42 is supposed to do exactly
what 0x41 does, and that the LOG_UNIMP should maybe just be removed).
thanks
-- PMM