[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 0/4] RDMA patches

From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PULL 0/4] RDMA patches
Date: Thu, 8 Feb 2018 16:06:14 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 08/02/2018 15:54, Peter Maydell wrote:
> On 8 February 2018 at 13:38, Marcel Apfelbaum <address@hidden> wrote:
>> Hi Peter,
>> On 08/02/2018 14:59, Peter Maydell wrote:
>>> (3) Some of the new headers use kernel-internals __u32 etc types.
>>> This isn't portable. ('HACKING' has some suggestions for types you
>>> might want instead.)
>> We do not "use" the __u32 types, we just copied a kernel file
>> for structures used for communication between the guest driver
>> and the QEMU code. We had a look on how it is done and
>> we use the model that adds macros __u32 -> uint32_t,
>> so the "__types" do not really create such problems.
> If we're using kernel header files, I would recommend using
> the scripts/update-headers machinery for this, the way we do
> for other kernel headers. Among other things, the cp_portable
> function in that script will fix up the type names for you.

I will use the mechanism.

> thanks
> -- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]