[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 0/4] RDMA patches

From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PULL 0/4] RDMA patches
Date: Thu, 8 Feb 2018 16:07:40 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 08/02/2018 15:58, Michael S. Tsirkin wrote:
> On Thu, Feb 08, 2018 at 03:38:59PM +0200, Marcel Apfelbaum wrote:
>> We do not "use" the __u32 types, we just copied a kernel file
>> for structures used for communication between the guest driver
>> and the QEMU code. We had a look on how it is done and
>> we use the model that adds macros __u32 -> uint32_t,
>> so the "__types" do not really create such problems.
> I don't think this is done like this anywhere in code.

It is used in vmxnet.

> Please take a look at how it's done for e.g. input.h

I will use it as reference.

> I think that whenever a rule in HACKING, coding style,
> etc is ignored it should be accompanied by motivation
> in code comments, so this won't spread out any more.

Agreed, I will update the code accordingly.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]