[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] S390: Expose s390-specific CPU info
Date: Thu, 8 Feb 2018 09:19:41 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/08/2018 03:48 AM, Viktor Mihajlovski wrote:
Presently s390x is the only architecture not exposing specific
CPU information via QMP query-cpus. Upstream discussion has shown
that it could make sense to report the architecture specific CPU
state, e.g. to detect that a CPU has been stopped.

With this change the output of query-cpus will look like this on

     [{"arch": "s390", "current": true,
       "props": {"core-id": 0}, "cpu_state": "operating", "CPU": 0,
       "qom_path": "/machine/unattached/device[0]",
       "halted": false, "thread_id": 63115},
      {"arch": "s390", "current": false,
       "props": {"core-id": 1}, "cpu_state": "stopped", "CPU": 1,
       "qom_path": "/machine/unattached/device[1]",
       "halted": true, "thread_id": 63116}]

Signed-off-by: Viktor Mihajlovski <address@hidden>

+++ b/qapi-schema.json
@@ -413,7 +413,7 @@
  # Since: 2.6
  { 'enum': 'CpuInfoArch',
-  'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'other' ] }
+  'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 's390', 'other' ] }

Missing a documentation line that mentions when the enum grew. Also, has a conflict with this other proposed addition, which demonstrates what the documentation should look like (should be easy to resolve, though):

+# @CpuInfoS390State:
+# An enumeration of cpu states that can be assumed by a virtual
+# S390 CPU
+# Since: 2.12
+{ 'enum': 'CpuInfoS390State',
+  'data': [ 'uninitialized', 'stopped', 'check_stop', 'operating', 'load' ] }

Is there a consistency reason for naming this 'check_stop', or can we go with our preference for using dash 'check-stop'?

+# @CpuInfoS390:
+# Additional information about a virtual S390 CPU
+# @cpu_state: the CPUs state
+# Since: 2.12
+{ 'struct': 'CpuInfoS390', 'data': { 'cpu_state': 'CpuInfoS390State' } }

Likewise for 'cpu-state'

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]