[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] build-sys: enable sanitizers by default wit
Re: [Qemu-devel] [PATCH 3/3] build-sys: enable sanitizers by default with --enable-debug
Fri, 9 Feb 2018 10:24:01 +0800
On Thu, 02/08 20:03, Marc-André Lureau wrote:
> On Thu, Feb 8, 2018 at 6:46 PM, Paolo Bonzini <address@hidden> wrote:
> > On 08/02/2018 17:23, Marc-André Lureau wrote:
> >> The original commit 247724cb302af5d70c8853154b640dfabf2bbb56 was meant
> >> to enable sanitizers by default when --enable-debug, but failed
> >> because of a gcc static linking bug. Try to enable it back now that
> >> there is a stronger check.
> >> Signed-off-by: Marc-André Lureau <address@hidden>
> > I'm more afraid that there are quite a few reports from sanitizers. I
> > wonder if that makes --enable-debug unusable; as a non-user of
> > --enable-debug I'm a bit wary of pushing this patch.
> I understand the concern, but at the same time, people should care
> about fixing those. If they want to keep ignoring them (for bad
> reasons), they can --disable-sanitizers. At least, I would want to
> reach a point where no ASAN regression get introduced in x86 target.
> It would be nice if patchew warn on new ASAN reports for example.
Could you write a docker test for that?