[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap |
Date: |
Fri, 9 Feb 2018 11:45:46 +0100 |
Now that memory_region_sync_dirty_bitmap is NULL, we can unify its
loop with memory_global_dirty_log_sync's. The only difference is
that memory_region_sync_dirty_bitmap will no longer call log_sync on
FlatRanges that do have a zero dirty_log_mask, but this is okay because
video memory is always registered with the dirty page logging mechanism.
Signed-off-by: Paolo Bonzini <address@hidden>
---
memory.c | 23 ++---------------------
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/memory.c b/memory.c
index 74917a19eb..586de4556d 100644
--- a/memory.c
+++ b/memory.c
@@ -1990,7 +1990,7 @@ static void memory_region_sync_dirty_bitmap(MemoryRegion
*mr)
as = listener->address_space;
view = address_space_get_flatview(as);
FOR_EACH_FLAT_RANGE(fr, view) {
- if (fr->mr == mr) {
+ if (fr->dirty_log_mask && (!mr || fr->mr == mr)) {
MemoryRegionSection mrs = section_from_flat_range(fr, view);
listener->log_sync(listener, &mrs);
}
@@ -2509,26 +2509,7 @@ bool memory_region_present(MemoryRegion *container,
hwaddr addr)
void memory_global_dirty_log_sync(void)
{
- MemoryListener *listener;
- AddressSpace *as;
- FlatView *view;
- FlatRange *fr;
-
- QTAILQ_FOREACH(listener, &memory_listeners, link) {
- if (!listener->log_sync) {
- continue;
- }
- as = listener->address_space;
- view = address_space_get_flatview(as);
- FOR_EACH_FLAT_RANGE(fr, view) {
- if (fr->dirty_log_mask) {
- MemoryRegionSection mrs = section_from_flat_range(fr, view);
-
- listener->log_sync(listener, &mrs);
- }
- }
- flatview_unref(view);
- }
+ memory_region_sync_dirty_bitmap(NULL);
}
void memory_global_after_dirty_log_sync(void)
--
2.14.3
- [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, Paolo Bonzini, 2018/02/09
- [Qemu-devel] [PATCH 3/4] memory: introduce memory_global_after_dirty_log_sync, Paolo Bonzini, 2018/02/09
- [Qemu-devel] [PATCH 1/4] memory: remove memory_region_test_and_clear_dirty, Paolo Bonzini, 2018/02/09
- [Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 2/4] memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot, Paolo Bonzini, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, no-reply, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, no-reply, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, no-reply, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, Dr. David Alan Gilbert, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, Dr. David Alan Gilbert, 2018/02/13