Re: [Qemu-devel] [PATCH 06/27] qcow2: Use QCryptoBlockCreateOptions in qcow2_create2()

[Eric Blake]

On 02/08/2018 01:23 PM, Kevin Wolf wrote:
> Instead of passing the encryption format name and the QemuOpts down, use
> the QCryptoBlockCreateOptions contained in BlockdevCreateOptions.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>   block/qcow2.c | 62 +++++++++++++++++++++++++++++++++++++++++++----------------
>   1 file changed, 45 insertions(+), 17 deletions(-)

> @@ -3010,6 +3026,7 @@ static int qcow2_create(const char *filename, QemuOpts 
> *opts, Error **errp)
>           ret = -EINVAL;
>           goto finish;
>       }
> +
>       encryptfmt = qemu_opt_get_del(opts, BLOCK_OPT_ENCRYPT_FORMAT);
>       if (encryptfmt) {
>           if (qemu_opt_get(opts, BLOCK_OPT_ENCRYPT)) {

Should this whitespace change belong to a different patch?

R-b still stands

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org