Re: [Qemu-devel] [PATCH V9 1/4] mem: add share parameter to memory-backend-ram

[Marcel Apfelbaum]

Hi Eduardo,

[This is a re-send, I didn't see the response
 on the mailing list, sorry for the spam]

On 08/02/2018 23:00, Eduardo Habkost wrote:
> On Thu, Feb 01, 2018 at 10:55:08PM +0200, Marcel Apfelbaum wrote:
>> Currently only file backed memory backend can
>> be created with a "share" flag in order to allow
>> sharing guest RAM with other processes in the host.
>>
>> Add the "share" flag also to RAM Memory Backend
>> in order to allow remapping parts of the guest RAM
>> to different host virtual addresses. This is needed
>> by the RDMA devices in order to remap non-contiguous
>> QEMU virtual addresses to a contiguous virtual address range.
>>
>> Moved the "share" flag to the Host Memory base class,
>> modified phys_mem_alloc to include the new parameter
>> and a new interface memory_region_init_ram_shared_nomigrate.
>>
>> There are no functional changes if the new flag is not used.
>>
>> Signed-off-by: Marcel Apfelbaum <address@hidden>
> 
> Code looks correct, so:
> 
> Reviewed-by: Eduardo Habkost <address@hidden>
> 

Appreciated!

> But later can we please stop the explosion of memory_init_ram*()
> functions and replace them with a single function with a flags
> parameter?
> 

Sounds reasonable.


Thanks,
Marcel