[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/48] Revert "build-sys: silence make by default or
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 01/48] Revert "build-sys: silence make by default or V=0" |
Date: |
Tue, 13 Feb 2018 13:00:05 +0100 |
From: "Daniel P. Berrange" <address@hidden>
This reverts commit 42a77f1ce4934b243df003f95bda88530631387a.
The primary intention of this change was to silence messages
like
make[1]: '/home/berrange/src/virt/qemu/capstone/libcapstone.a' is up to date.
which we get when calling make recursively with explicit
targets.
The problem is that this change affected every make target,
not merely the targets that triggered these "is up to date"
messages. As a result any targets that were not invoking
commands via "$(call quiet-command ...)" suddenly become
silent. This is particularly bad for "make install" which
now appears todo nothing.
Rather than go through every make rule and try to identify
places where we now need to explicitly print a message to
show work taking place, just revert the change.
To address the original problem of silencing "is up to date"
messages, we simply add --quiet to the SUBDIR_MAKEVARS
variable, so it only affects us on recursive make calls.
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-Id: <address@hidden>
Tested-by: Eric Blake <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
Makefile | 2 +-
rules.mak | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 4ec7a3c..9b4291b 100644
--- a/Makefile
+++ b/Makefile
@@ -294,7 +294,7 @@ else
DOCS=
endif
-SUBDIR_MAKEFLAGS=BUILD_DIR=$(BUILD_DIR)
+SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory --quiet)
BUILD_DIR=$(BUILD_DIR)
SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS))
SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d, $(TARGET_DIRS))
diff --git a/rules.mak b/rules.mak
index 5fb4951..6e94333 100644
--- a/rules.mak
+++ b/rules.mak
@@ -131,8 +131,6 @@ modules:
# If called with only a single argument, will print nothing in quiet mode.
quiet-command = $(if $(V),$1,$(if $(2),@printf " %-7s %s\n" $2 $3 && $1, @$1))
-MAKEFLAGS += $(if $(V),,--no-print-directory --quiet)
-
# cc-option
# Usage: CFLAGS+=$(call cc-option, -falign-functions=0, -malign-functions=0)
--
1.8.3.1
- [Qemu-devel] [PULL 00/48] Misc patches for 2018-02-13, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 03/48] hax: Support guest RAM sizes of 4GB or more, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 05/48] net/can: support for connecting to Linux host SocketCAN interface., Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 02/48] make: fix help message reference to bogus V=0 variable, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 01/48] Revert "build-sys: silence make by default or V=0",
Paolo Bonzini <=
- [Qemu-devel] [PULL 04/48] net/can: simple messages transport implementation for QEMU, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 07/48] hw/net/can: Kvaser PCI CAN-S (single SJA1000 channel) emulation, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 10/48] net/can: documentation, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 09/48] hw/net/can: MIOe-3680 PCI (dual SJA1000 channel) emulation, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 08/48] hw/net/can: PCM-3680I PCI (dual SJA1000 channel) emulation, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 14/48] sdhci: use error_propagate(local_err) in realize(), Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 13/48] build-sys: check static linking of UBSAN, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 17/48] sdhci: add a check_capab_baseclock() qtest, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 06/48] hw/net/can: SJA1000 chip register level emulation for QEMU, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 18/48] sdhci: add a check_capab_sdma() qtest, Paolo Bonzini, 2018/02/13