[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 47/48] memory: unify loops to sync dirty log bitmap
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 47/48] memory: unify loops to sync dirty log bitmap |
Date: |
Tue, 13 Feb 2018 13:00:51 +0100 |
Now that memory_region_sync_dirty_bitmap is NULL, we can unify its
loop with memory_global_dirty_log_sync's. The only difference is
that memory_region_sync_dirty_bitmap will no longer call log_sync on
FlatRanges that do have a zero dirty_log_mask, but this is okay because
video memory is always registered with the dirty page logging mechanism.
Signed-off-by: Paolo Bonzini <address@hidden>
---
memory.c | 23 ++---------------------
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/memory.c b/memory.c
index 8ed809c..c7f6588 100644
--- a/memory.c
+++ b/memory.c
@@ -1990,7 +1990,7 @@ static void memory_region_sync_dirty_bitmap(MemoryRegion
*mr)
as = listener->address_space;
view = address_space_get_flatview(as);
FOR_EACH_FLAT_RANGE(fr, view) {
- if (fr->mr == mr) {
+ if (fr->dirty_log_mask && (!mr || fr->mr == mr)) {
MemoryRegionSection mrs = section_from_flat_range(fr, view);
listener->log_sync(listener, &mrs);
}
@@ -2506,26 +2506,7 @@ bool memory_region_present(MemoryRegion *container,
hwaddr addr)
void memory_global_dirty_log_sync(void)
{
- MemoryListener *listener;
- AddressSpace *as;
- FlatView *view;
- FlatRange *fr;
-
- QTAILQ_FOREACH(listener, &memory_listeners, link) {
- if (!listener->log_sync) {
- continue;
- }
- as = listener->address_space;
- view = address_space_get_flatview(as);
- FOR_EACH_FLAT_RANGE(fr, view) {
- if (fr->dirty_log_mask) {
- MemoryRegionSection mrs = section_from_flat_range(fr, view);
-
- listener->log_sync(listener, &mrs);
- }
- }
- flatview_unref(view);
- }
+ memory_region_sync_dirty_bitmap(NULL);
}
static VMChangeStateEntry *vmstate_change;
--
1.8.3.1
- [Qemu-devel] [PULL 33/48] sdbus: add trace events, (continued)
- [Qemu-devel] [PULL 33/48] sdbus: add trace events, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 29/48] hw/arm/xilinx_zynq: fix the capabilities register to match the datasheet, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 31/48] sdhci: rename the hostctl1 register, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 40/48] hw/arm/xilinx_zynqmp: enable the UHS-I mode, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 37/48] hw/arm/bcm2835_peripherals: change maximum block size to 1kB, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 38/48] hw/arm/fsl-imx6: implement SDHCI Spec. v3, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 39/48] hw/arm/xilinx_zynqmp: fix the capabilities/spec version to match the datasheet, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 42/48] sdhci: add a check_capab_v3() qtest, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 48/48] travis: use libgcc-4.8-dev (libgcc-6-dev is not available on Ubuntu 14.04), Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 43/48] sdhci: add Spec v4.2 register definitions, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 47/48] memory: unify loops to sync dirty log bitmap,
Paolo Bonzini <=
- [Qemu-devel] [PULL 44/48] g364fb: switch to using DirtyBitmapSnapshot, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 41/48] sdhci: check Spec v3 capabilities qtest, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 46/48] memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot, Paolo Bonzini, 2018/02/13
- [Qemu-devel] [PULL 45/48] memory: remove memory_region_test_and_clear_dirty, Paolo Bonzini, 2018/02/13
- Re: [Qemu-devel] [PULL 00/48] Misc patches for 2018-02-13, Peter Maydell, 2018/02/13