[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB |
Date: |
Tue, 13 Feb 2018 19:45:07 +0000 |
On 13 February 2018 at 16:41, Geert Uytterhoeven
<address@hidden> wrote:
> It is not uncommon for a contemporary FDT to be larger than 64 KiB,
> leading to failures loading the device tree from sysfs:
>
> qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE
>
> For reference, the largest arm64 DTB created from the Linux sources is
> 70 KiB large (93 KiB when built with symbols/fixup support).
I think we should probably give ourselves a bit more headroom,
then -- at least 256K.
The ppc boards actually define their own version of this constant:
#define FDT_MAX_SIZE 0x00100000
so I think we might as well just go with that in device_tree.c for
consistency.
thanks
-- PMM