[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 16/21] vdi: Avoid bitrot of debugging code
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v8 16/21] vdi: Avoid bitrot of debugging code |
Date: |
Tue, 13 Feb 2018 14:26:56 -0600 |
Rework the debug define so that we always get -Wformat checking,
even when debugging is disabled.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
---
v2-v7: no change
---
block/vdi.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index fc1c614cb12..32b1763cde0 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -87,12 +87,18 @@
#define DEFAULT_CLUSTER_SIZE (1 * MiB)
#if defined(CONFIG_VDI_DEBUG)
-#define logout(fmt, ...) \
- fprintf(stderr, "vdi\t%-24s" fmt, __func__, ##__VA_ARGS__)
+#define VDI_DEBUG 1
#else
-#define logout(fmt, ...) ((void)0)
+#define VDI_DEBUG 0
#endif
+#define logout(fmt, ...) \
+ do { \
+ if (VDI_DEBUG) { \
+ fprintf(stderr, "vdi\t%-24s" fmt, __func__, ##__VA_ARGS__); \
+ } \
+ } while (0)
+
/* Image signature. */
#define VDI_SIGNATURE 0xbeda107f
--
2.14.3
- [Qemu-devel] [PATCH v8 15/21] sheepdog: Switch to .bdrv_co_block_status(), (continued)
- [Qemu-devel] [PATCH v8 19/21] vpc: Switch to .bdrv_co_block_status(), Eric Blake, 2018/02/13
- [Qemu-devel] [PATCH v8 21/21] block: Drop unused .bdrv_co_get_block_status(), Eric Blake, 2018/02/13
- [Qemu-devel] [PATCH v8 16/21] vdi: Avoid bitrot of debugging code,
Eric Blake <=
- [Qemu-devel] [PATCH v8 18/21] vmdk: Switch to .bdrv_co_block_status(), Eric Blake, 2018/02/13
- Re: [Qemu-devel] [PATCH v8 00/21] add byte-based block_status driver callbacks, Kevin Wolf, 2018/02/14