Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

[Stefan Hajnoczi]

On Wed, Feb 14, 2018 at 09:01:11AM +0800, Fam Zheng wrote:
> On Tue, 02/13 18:09, Daniel P. Berrangé wrote:
> > On Tue, Feb 13, 2018 at 05:34:25PM +0000, Stefan Hajnoczi wrote:
> > > +[gitpublishprofile "block"]
> > > +base = master
> > > +prefix = PATCH
> > > +to = address@hidden
> > > +cc = address@hidden
> > > +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit 
> > > --nogit-fallback 2>/dev/null
> > 
> > Why is a custom entry needed for block here (and other things
> > below).   Won't running get_maintainer.pl already correctly
> > report when a patch needs cc'ing to address@hidden
> > based on MAINTAINER rules ?
> 
> Yeah, dropping them should be fine. What do you think, Stefan?

scripts/get_maintainer.pl only works when patches touch files associated
with address@hidden in MAINTAINERS.  It would be
counter-intuitive for --profile block to not include
address@hidden, so I think these entries do serve a purpose.

On the other hand, I personally just use --cc qemu-block instead of a
profile for this.  I'll probably only use the default profile.

Fam, if you want it dropped, let me know.  Otherwise, we can leave it
in if there is no further discussion.

Stefan

signature.asc
Description: PGP signature